Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide rewards in rendertransaction #160

Closed

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Feb 15, 2024

Resolves #155

  • Applied the same conditional from init() into renderTransaction(), didn't see that it also set the text in that function too.

  • QA: I just spoofed a permit claim with the same permit I claimed earlier by muting anything that would decline it but looks to be working now, not sure whether I have a functional bot I can generate and claim acc permits through rn or not so I hope this is enough, should be sorted.

bandicam.2024-02-15.13-05-58-635.mp4

@Keyrxng Keyrxng requested a review from 0x4007 as a code owner February 15, 2024 13:13
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include all the changes? I reverted them so you need to include everything you did. This seems small.

@Keyrxng Keyrxng closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic Enhancements
2 participants