Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(just): clean up ujust recipes to fit newer style #1914

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

tulilirockz
Copy link
Collaborator

Should fix #1805

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 10, 2024
@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

We should also use this as an opportunity to clean up stale ones.

just/bluefin-system.just Outdated Show resolved Hide resolved
just/bluefin-system.just Outdated Show resolved Hide resolved
just/bluefin-system.just Outdated Show resolved Hide resolved
@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

when working with the justfiles. Please be sure to run just fix. We run just check as part of the workflow to make sure we don't ship broken justfiles.

@tulilirockz tulilirockz force-pushed the switch-channels branch 2 times, most recently from d51c42e to 3d7f301 Compare November 10, 2024 15:43
@tulilirockz tulilirockz changed the title chore(just): make aliases into recipes to get autocompletion chore(just): clean up ujust recipes to fit newer style Nov 13, 2024
@tulilirockz tulilirockz marked this pull request as draft November 13, 2024 04:28
@tulilirockz
Copy link
Collaborator Author

Should I also include a move to bootc on this PR? I am thinking about refactoring most of these scripts to not use rpm-ostree and instead use a wrapper over bootc that allows it to run rootless (ubootc or something)

@tulilirockz
Copy link
Collaborator Author

The indentation on some places also seems a bit funky, ill be reformatting them to always fit 4 spaces indentation

@castrojo
Copy link
Member

Should I also include a move to bootc on this PR?

Follow on PRs are always better instead of conflating things.

a wrapper over bootc that allows it to run rootless (ubootc or something)

This is out of scope for us, we're trying to delete as much of our custom stuff as possible these days.

just/bluefin-system.just Outdated Show resolved Hide resolved
@tulilirockz
Copy link
Collaborator Author

Now the idea was to remove a few old ones, like the pytorch, gnome-vrr, (...) - Anyone has any guesses what to remove? Ill make a little list that i feel that could be deleted

@tulilirockz
Copy link
Collaborator Author

Then we could regroup stuff, honestly I feel like separating it in apps, tools and system doesnt seem like the best? apps and tools could be the same category (tools)

@castrojo
Copy link
Member

We need to keep jetbrains (people comment about how useful this is all the time), and the tailscale toggle was an ask in the survey. So let's keep that for people who use other VPNs. Not sure on invokeai so let's keep it for now. We can always do another pass.

@castrojo
Copy link
Member

OK one final pass from others would be appreciated on this one! (I know m2 wanted one more look).

Copy link
Contributor

@befanyt befanyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found something that probably needs a second look, not sure if it needs to be fixed as part of this PR. But just letting you all know.

just/bluefin-system.just Outdated Show resolved Hide resolved
@tulilirockz tulilirockz marked this pull request as ready for review November 17, 2024 17:58
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 17, 2024
@tulilirockz
Copy link
Collaborator Author

Alright, so, after manually testing every single one of the affected recipes, they all seem to work fine, without any major changes. The only ones that I saw that were broken were the toggle-tailscale and setup-ollama ones - just reverted them. The tailscale one also didnt seem to toggle the extension on the Silverblue $VARIANT so I just made it uppercase :p

For some reason this didnt get caught by `just fix`. Reverted them + made it so the extension actually gets toggled
@castrojo castrojo added this pull request to the merge queue Nov 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
Merged via the queue into ublue-os:main with commit 3595ea8 Nov 18, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ujust switch-channel alias is broken
4 participants