-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(just): clean up ujust recipes to fit newer style #1914
Conversation
We should also use this as an opportunity to clean up stale ones. |
170d8da
to
3b46d0e
Compare
when working with the justfiles. Please be sure to run |
d51c42e
to
3d7f301
Compare
Should I also include a move to bootc on this PR? I am thinking about refactoring most of these scripts to not use rpm-ostree and instead use a wrapper over bootc that allows it to run rootless (ubootc or something) |
The indentation on some places also seems a bit funky, ill be reformatting them to always fit 4 spaces indentation |
Follow on PRs are always better instead of conflating things.
This is out of scope for us, we're trying to delete as much of our custom stuff as possible these days. |
3d7f301
to
4edd9fa
Compare
4edd9fa
to
add528b
Compare
Now the idea was to remove a few old ones, like the pytorch, gnome-vrr, (...) - Anyone has any guesses what to remove? Ill make a little list that i feel that could be deleted
|
Then we could regroup stuff, honestly I feel like separating it in |
a52b2f8
to
1cf9a4d
Compare
We need to keep jetbrains (people comment about how useful this is all the time), and the tailscale toggle was an ask in the survey. So let's keep that for people who use other VPNs. Not sure on invokeai so let's keep it for now. We can always do another pass. |
1cf9a4d
to
0dd670c
Compare
OK one final pass from others would be appreciated on this one! (I know m2 wanted one more look). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found something that probably needs a second look, not sure if it needs to be fixed as part of this PR. But just letting you all know.
Alright, so, after manually testing every single one of the affected recipes, they all seem to work fine, without any major changes. The only ones that I saw that were broken were the toggle-tailscale and setup-ollama ones - just reverted them. The tailscale one also didnt seem to toggle the extension on the |
For some reason this didnt get caught by `just fix`. Reverted them + made it so the extension actually gets toggled
76ff4d9
to
e71965a
Compare
Should fix #1805