This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
forked from JasonN3/build-container-installer
-
Notifications
You must be signed in to change notification settings - Fork 2
chore: remove dnf cache and unused files from built image #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelmiller
suggested changes
Feb 26, 2024
JasonN3
previously approved these changes
Feb 27, 2024
@bsherman thoughts? |
Have switched to a .dockerignore instead. That way, we are including files by default, instead of the previous way of excluding them by default. |
noelmiller
approved these changes
Feb 29, 2024
🤦 I cancelled the builds in the wrong tab. Will rerun them. |
bsherman
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove dnf cached files from the image before publishing it.
Also we don't need to include files like the devcontainer config or action.yml in the image, so only including the necessary files.