Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

chore: remove dnf cache and unused files from built image #26

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented Feb 22, 2024

We should remove dnf cached files from the image before publishing it.
Also we don't need to include files like the devcontainer config or action.yml in the image, so only including the necessary files.

@p5 p5 marked this pull request as ready for review February 22, 2024 17:03
@p5 p5 requested a review from JasonN3 as a code owner February 22, 2024 17:03
@p5 p5 marked this pull request as draft February 22, 2024 17:11
@p5 p5 marked this pull request as ready for review February 22, 2024 20:17
Containerfile Outdated Show resolved Hide resolved
JasonN3
JasonN3 previously approved these changes Feb 27, 2024
@p5 p5 requested a review from noelmiller February 28, 2024 10:16
@noelmiller
Copy link
Member

noelmiller commented Feb 28, 2024

entrypoint.sh also needs to be copied over. I'm starting to think saving space on the action.yml, LICENSE file, README.md, and Containerfile isn't worth the hassle of continuing to add files to the list of things copied into the container.

@bsherman thoughts?

@p5
Copy link
Member Author

p5 commented Feb 29, 2024

entrypoint.sh also needs to be copied over. I'm starting to think saving space on the action.yml, LICENSE file, README.md, and Containerfile isn't worth the hassle of continuing to add files to the list of things copied into the container.

Have switched to a .dockerignore instead. That way, we are including files by default, instead of the previous way of excluding them by default.

@p5
Copy link
Member Author

p5 commented Feb 29, 2024

🤦 I cancelled the builds in the wrong tab. Will rerun them.
Sorry

@noelmiller noelmiller requested a review from bsherman February 29, 2024 19:43
@noelmiller noelmiller added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit aa4aecd Feb 29, 2024
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants