refactor: parse url in get_snap_name

ubuntu · Dec 11, 2024 · 23704ec · 23704ec
1 parent c4332a2
commit 23704ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/ratings/categories.rs b/src/ratings/categories.rs
@@ -83,10 +83,9 @@ async fn get_snap_categories(
     base: &str,
     client: &reqwest::Client,
 ) -> Result<Vec<Category>, Error> {
-    let base_url = reqwest::Url::parse(base).map_err(|e| Error::InvalidUrl(e.to_string()))?;
-
-    let snap_name = get_snap_name(snap_id, &base_url, client).await?;
+    let snap_name = get_snap_name(snap_id, base, client).await?;
 
+    let base_url = reqwest::Url::parse(base).map_err(|e| Error::InvalidUrl(e.to_string()))?;
     let info_url = base_url
         .join(&format!("snaps/info/{snap_name}"))
         .map_err(|e| Error::InvalidUrl(e.to_string()))?;

diff --git a/src/ratings/mod.rs b/src/ratings/mod.rs
@@ -63,9 +63,10 @@ async fn get_json<T: DeserializeOwned>(
 )]
 async fn get_snap_name(
     snap_id: &str,
-    base_url: &reqwest::Url,
+    base: &str,
     client: &reqwest::Client,
 ) -> Result<String, Error> {
+    let base_url = reqwest::Url::parse(base).map_err(|e| Error::InvalidUrl(e.to_string()))?;
     let assertions_url = base_url
         .join(&format!("assertions/snap-declaration/16/{snap_id}"))
         .map_err(|e| Error::InvalidUrl(e.to_string()))?;