feat: not_found error status handled

ubuntu · Dec 6, 2023 · 3952941 · 3952941
1 parent b76bcaf
commit 3952941
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/features/chart/errors.rs b/src/features/chart/errors.rs
@@ -6,4 +6,6 @@ pub enum ChartError {
     FailedToGetChart,
     #[error("unknown chart error")]
     Unknown,
+    #[error("could not find data for given timeframe")]
+    NotFound,
 }
diff --git a/src/features/chart/infrastructure.rs b/src/features/chart/infrastructure.rs
@@ -44,7 +44,7 @@ pub(crate) async fn get_votes_summary_by_timeframe(
         .await
         .map_err(|error| {
             error!("{error:?}");
-            ChartError::Unknown
+            ChartError::NotFound
         })?;
 
     Ok(result)

diff --git a/src/features/chart/interface.rs b/src/features/chart/interface.rs
@@ -5,6 +5,7 @@ use tonic::{Request, Response, Status};
 
 use crate::features::pb::chart::chart_server::Chart;
 
+use super::errors::ChartError;
 use super::{service::ChartService, use_cases};
 
 #[tonic::async_trait]
@@ -41,7 +42,12 @@ impl Chart for ChartService {
                 };
                 Ok(Response::new(payload))
             }
-            Err(_error) => Err(Status::unknown("Internal server error")),
+            Err(error) => match error {
+                ChartError::NotFound => {
+                    Err(Status::not_found("Cannot find data for given timeframe."))
+                }
+                _ => Err(Status::unknown("Internal server error")),
+            },
         }
     }
 }