Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tonic tls termination #146

Closed
wants to merge 67 commits into from
Closed

Tonic tls termination #146

wants to merge 67 commits into from

Conversation

matthew-hagemann
Copy link
Collaborator

No description provided.

sminez and others added 30 commits November 19, 2024 12:41
@sminez @d-loose
chore: adding initial TODO file to track the work we want to cover
cfda00e
@sminez @d-loose
refactor: restructuring as a monorepo for the rewrite
cde272c
@sminez @d-loose
refactor: tidying up stub crate structure for ratings_new
be8efd5
@d-loose
chore: update dependencies and enable features
a4b47ef
@d-loose
chore: copy sql migrations from ratings crate
500772b
@d-loose
chore: copy config and migrator utils from ratings crate
982a4cf
@d-loose
feat: setup database
d5f2812
@d-loose
chore: copy common UserError from ratings crate
c548a0e
@d-loose
feat: add User struct + db methods
ccdb6c4
@d-loose
feat: setup Vote struct + db methods
5108f9a
@d-loose
test: test User + Vote roundtrip
770460a
@d-loose
feat: add get_all_by_user to Vote and delete to User
b061c41
@d-loose
refactor(db): remove Unknown user error
9ed5867
@d-loose
fix: remove modules from main.rs
0d17df9
@d-loose
refactor: UserError->DbError, remove box errors where possible
fff4135
@d-loose
refactor: cleanup imports
91dedc2
@d-loose
refactor: use OnceCell for Config
ce03e24
@d-loose
refactor: add db::Result type
2df134e
@d-loose
refactor: rename PgConnection arg, move to end
c80bdaf
@d-loose
feat: remove FromRow trait from User
3a653e3 
This helps ensure data in a User struct always comes from the DB.
@d-loose
fix: remove redundant get_all_by_user method
be93383
@d-loose
feat: add categories module
7d1bd69
@d-loose
refactor: remove Categories namespace
9e381da
@sminez
Merge pull request ubuntu#132 from ubuntu/db-layer
422c063 
feat: add database layer for new architecture
@sminez
feat: stubbing out the application layer
80e5d22
@sminez
fix: ensuring that db tests only run when explicitly requested
67a437f
@sminez
fix: remove internal Arcs from context
3ad624d
@sminez
Merge pull request ubuntu#143 from ubuntu/rewrite-application-layer
e509cfd 
feat: stub out the new application layer
@matthew-hagemann
ci: codecov is not a failure in ci
3df21e9
@sminez @matthew-hagemann
chore: adding initial TODO file to track the work we want to cover
eeeaae9
matthew-hagemann and others added 27 commits November 20, 2024 16:12
@matthew-hagemann
refactor: feedback from pairing session
16da50e
@matthew-hagemann
refactor: merging charts files into grpc/charts.rs
274da3b
@matthew-hagemann
feat: log error before losing detail in chart.rs
ebe385b
@matthew-hagemann
fix: add strum dependency
04bbf7e
@matthew-hagemann
style: run the formatter
3ae08db
@matthew-hagemann
refactor: merging ratings files into grpc/app.rs
7efa346
@matthew-hagemann
chore: additional post rebase cleanup
5ca6a99
@matthew-hagemann
refactor: swap AppContext for Context in gPRC layer
7809059
@matthew-hagemann
refactor: user gRPC layer to use ratings_new functions
c2f1064
@matthew-hagemann
refactor: chart gRPC layer to use ratings_new functions
8ee2d59
@matthew-hagemann @sminez
chore: re-adding tests accidentally deleted in rebase
637d75f 
I accidentally removed these in one of the rebase's. Co-authoring Innes as he wrote the tests.

Co-authored-by: Innes Anderson-Morrison <[email protected]>
@matthew-hagemann
chore: removing auth.rs in favor of context.rs
f834f35
@matthew-hagemann
refactor: make use of db types and common error where possible
f260583
@matthew-hagemann
style: run the formatter
93d2ddd
@matthew-hagemann @sminez
refactor: use conn!() macro, add FIXME's
13cf86f 
Co-authored-by: Innes Anderson-Morrison <[email protected]>
@sminez
Merge pull request ubuntu#142 from matthew-hagemann/grpc-layer-refactor
4e9a392 
refactor: gRPC layer refactor
@sminez
refactor: wiring in the application layer
4a01fd8
@sminez
fix: simplifying use of config
910337a
@sminez
refactor: simplifying match
ed61a26
@sminez
Merge pull request ubuntu#144 from ubuntu/rewrite-wiring-up
4571f30 
refactor: wiring in the application layer
@sminez
refactor: copying proto files and tests into ratings_new so we can ru…
571481a 
…n the integration tests
@sminez
chore: updating docker-compose.yml to run the new version of the server
65c4235
@sminez
feat: adding in auth and server init
2cde744
@sminez
fix: removing duplicated generated files
f2590aa
@sminez
fix: removing duplicated Cargo.lock
07d8230
@sminez
fix: updating gitignore
e5802f3
@matthew-hagemann
wip: tls termination
f3f85a0
@sminez sminez deleted the branch ubuntu:rewrite November 26, 2024 11:24
@sminez sminez closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthew-hagemann @sminez @d-loose