-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add snap_name
to Rating
and Vote
messages
#153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
force-pushed
the
snap-names-in-charts
branch
from
December 12, 2024 15:23
7acd796
to
2a2b964
Compare
d-loose
changed the title
feat: add
feat: add Dec 12, 2024
snap_name
to Rating
messagesnap_name
to Rating
and Vote
messages
@sminez I've moved all of the snap name resolving logic to the grpc layer now. I'm still using |
sminez
reviewed
Dec 12, 2024
d-loose
force-pushed
the
snap-names-in-charts
branch
from
December 12, 2024 16:19
64c8fb6
to
035f6c7
Compare
sminez
approved these changes
Dec 12, 2024
d-loose
added a commit
to ubuntu/app-center
that referenced
this pull request
Dec 17, 2024
Follow-up to ubuntu/app-center-ratings#153 Uses the `snap_name` field added to `Rating` and `Vote` server-side, which eliminates the need to resolve `snap_id`s into `snap_name`s in the app-center. Since this needs a regeneration of the protobuf files, I've also removed the `listMyVotes` methods following ubuntu/app-center-ratings#151. UDENG-5628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
snap_name
to theRating
message which is part ofGetRatingResponse
andGetChartResponse
. This spares us from having to resolvesnap_id
s intosnap_name
s in the app-center when requesting top charts from the server.To simplify the transition from
snap_id
s tosnap_names
in the future, this also adds asnap_name
field to theVote
message.UDENG-5628