Add Rest endpoints #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoopOTheGoop
force-pushed
the
rest-endpoints
branch
4 times, most recently
from
1a67201 to
a5ca5b2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZoopOTheGoop
force-pushed
the
rest-endpoints
branch
7 times, most recently
from
c5bffcf to
a7f6823
Compare
ZoopOTheGoop
force-pushed
the
rest-endpoints
branch
from
a7f6823 to
4a2453e
Compare
ZoopOTheGoop
force-pushed
the
rest-endpoints
branch
from
15e84b0 to
2a6da11
Compare
Currently, tests use `init_tracing` for prettier logging, but this conflicts with `Infrastructure`, which initializes logging inside itself.
added 2 commits
March 7, 2024 22:31
REST is going to require admin authentication, instead of the JWT token signing we do now just for valid client hashes. So we need to move the authentication to a more reusable form. This has a couple incidental changes like introducing `secrecy` which lets us shred secrets in memory when they go out of scope. Minor benefit, but I added it for the password secrets so may as well use it for JWT too.
ZoopOTheGoop
force-pushed
the
rest-endpoints
branch
from
106d5b2 to
a4d2af1
Compare
added 5 commits
March 8, 2024 00:56
Since the authenticator got moved out of GRPC into its own thing, the two servers both live alone in a module folder, so just move them up a level because it's cleaner.
tim-hm
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
This looks great! As discussed on our call there are some bits to revisit down the road but I think this can be merged as-is.
Bits to revisit:
- We don't expose admin endpoints publicly so do they need user/pass?
- In the event we need to toggle the log level live, probably easier as a query parameter, for example
GET /v1/admin/log_level?level=info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both relatively simple implementations and multiplexing a REST endpoint is the only "hard" part.
Requires #88 being merged.
Fixes #63 Fixes #64