Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Look for watch standby and watch progress cursors #4160

Merged
merged 24 commits into from
Nov 20, 2024

Conversation

ochi12
Copy link
Contributor

@ochi12 ochi12 commented Nov 17, 2024

Suggested task from @Muqtxdir linking to #4134.

This PR is a continuation of the issue raised in #4132

Changes include simpler spinner design based on #4132

Screen Cast

image
image

@ochi12
Copy link
Contributor Author

ochi12 commented Nov 17, 2024

@Muqtxdir the progress animated cursor at the 24x24 size is an issue for me. 1px is too small, 2px is fine but is not a pixel fit. It looks good on sizes greater than 24 x 24 tho. I can't force it for a 3 pixels gap, it will result to large looking gaps for cursor size greater than 24x24.

@ochi12 ochi12 changed the title Initial revamp watch standby and watch progress Initial Look for watch standby and watch progress cursors Nov 17, 2024
@Feichtmeier
Copy link
Member

wow I wouldnt have thought that this looks indeed better !

@Muqtxdir
Copy link
Member

thanks, I'll checkout your branch locally and see

ochi12 and others added 4 commits November 18, 2024 16:53
…tu#4159)

* created symbolic links named org.gnome.Snapshot pointing to camera-app to supliment missing yaru icon for gnome-snapshot

* replace gnome-snapshot links targeting camera-app<or -symbolic>.<png or svg> with custom icon instead

* reworked org.gnome.Snapshot-symbolic
* GnomeShell: Yaruify upstream icons

* chore: optimize `actions` symbolics

* chore: optimize symbolics under `status`

---------

Co-authored-by: Muqtxdir <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ochi12 ochi12 changed the base branch from master to chore/spinner-style November 18, 2024 12:01
@ochi12
Copy link
Contributor Author

ochi12 commented Nov 19, 2024

I still can't find the problem that causes the wait animated cursor to jitter <<<already fixed>>>

Screencast.from.2024-11-18.19-37-57.webm

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Muqtxdir Muqtxdir merged commit c645f6b into ubuntu:chore/spinner-style Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants