Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move backoff settings as well as other functions out of utils #1209

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AlbertSnows
Copy link
Contributor

@AlbertSnows AlbertSnows commented Jan 10, 2025

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11392

This PR moves config properties and functions out of utils into config. Utils should be low-level, and thus not reference other namespaces for sake of not inducing circular dependencies.
redesign of #1181

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

  • moved properties and functions out of utils to config or models to resolve cyclic dependencies

Deployment changes

@AlbertSnows AlbertSnows changed the title move backoff settings to config move backoff settings as well as other functions out of utils Jan 10, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12717987200

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 398 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.2%) to 75.399%

Files with Coverage Reduction New Missed Lines %
resources/audit/client.py 11 73.42%
resources/openid/ras_oauth2.py 16 58.65%
config.py 19 73.97%
init.py 20 90.76%
models.py 21 86.68%
utils.py 40 67.59%
resources/google/utils.py 51 77.19%
scripting/google_monitor.py 77 40.6%
scripting/fence_create.py 143 60.5%
Totals Coverage Status
Change from base Build 12356407492: 0.2%
Covered Lines: 7849
Relevant Lines: 10410

💛 - Coveralls

Copy link

Please find the ci env pod logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants