Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qh grants search page works #650

Draft
wants to merge 80 commits into
base: dev
Choose a base branch
from
Draft

Qh grants search page works #650

wants to merge 80 commits into from

Conversation

qjhart
Copy link
Collaborator

@qjhart qjhart commented Nov 8, 2024

This updates the upcoming grant search w/ changes to works as well.

Remember to change to dev base when pulling

UcDust and others added 30 commits September 27, 2024 14:38

// by default, filter out hidden works/grants if not requested to include them, or if not admin/expert
if( options['is-visible'] !== false || !options.admin ) {
console.log('filtering out hidden works/grants',doc['@id']);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UcDust / @rakunkel-ucd does anyone remember making this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qjhart I think I initially added that code to filter out works/grants, but it's further down in the file in the dev branch. I don't think I moved it in the file after initially adding it into that subselect function.

@UcDust UcDust mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants