Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed text overflow in title with character resizing and limit #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DynieM
Copy link

@DynieM DynieM commented Sep 23, 2024

Added a character limit and function to resize text the longer the length of the title is.

Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work as intended. Two quick recommendations and one fix:

  1. The initial font size could probably be a little bigger (it appears to be slightly smaller than the static header font size on prod)
  2. The text in the header is not vertically centered (it should center dynamically regardless of text length and word wrap).
  3. Your PR deletes the yarn lockfile, which it shouldn't. Ideally there should be no changes to the lockfile at all (you may have mistaken resetting changes with deleting the file completely?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants