Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution to the awesome-dash #47

Open
wants to merge 41 commits into
base: include-new-contributor
Choose a base branch
from

Conversation

pip-install-python
Copy link

Arranged the content in alphabetical order, also added some tutorials, popular components & a book

Do you want to be added to the contributors list on the README.md file?
  • [ ✅] Yes
  • No
What name would you like?

Pip Install Python

What website would you like your name linked to?

https://pip-install-python.com

ucg8j and others added 30 commits September 14, 2019 14:42
add some official introduction tutorials
add helper script to get potent. relevant gh repos
add pypi project query script
Add a new link to the Galleries section
Vaex dataframe + dash integration
added entry under example app
Remove invalid 'sd-data-table' reference
add dash_echarts to the component libraries!
Add Dash Mantine Components Library
Add the Books category with a link to my Dash book
Co-authored-by: Luke Singham <[email protected]>
ucg8j and others added 11 commits May 9, 2022 12:12
adding youtube channel to tutorial section
Fix broken wind streaming link
* Add dash-vega-components

* Add point
Organized the file's context by alphabetical order. Added some other tutorials, components and a dash book to the README.md
Copy link
Author

@pip-install-python pip-install-python left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added a new plotly logo in the image field, as the prior svg link was broken

Copy link
Owner

@ucg8j ucg8j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and firstly thank you for taking the time to contribute! Apologies for not seeing this earlier I didn't get a notification for it.

Regarding the changes I have a few pieces of feedback:

  • The image update is great, what do you think of saving the svg to the repo and using a relative reference to include it in the markdown? That way the image isn't prone to link rot.
  • The PR you've raised isn't on master, so the diff makes it hard to review what you've added in this PR. Could you re-raise on master?
  • Similar to the point above, separate commits for the changes you've made e.g. Add new tutorials, Alpha sort sections, particular giving you have alpha-sorted the list, which increases the diff to review.
    • Nit pick - I'd like to keep the Contributors as an append list to show the order of first contribution to the project.
  • The OG/meta awesome list is not alpha sorted, and it isn't included in the definition of the formatting of an awesome list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.