-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution to the awesome-dash #47
base: include-new-contributor
Are you sure you want to change the base?
Contribution to the awesome-dash #47
Conversation
Include Florian under contributors
add some official introduction tutorials
add helper script to get potent. relevant gh repos
add pypi project query script
Add a new link to the Galleries section
Vaex dataframe + dash integration
added entry under example app
Remove invalid 'sd-data-table' reference
add dash_echarts to the component libraries!
Update README.md
add dash-uploader
Add Dash Mantine Components Library
Add the Books category with a link to my Dash book
Co-authored-by: Luke Singham <[email protected]>
✨ add plotly-resampler
adding youtube channel to tutorial section
Fix broken wind streaming link
Update Bigfoot Dash links.
* Add dash-vega-components * Add point
Organized the file's context by alphabetical order. Added some other tutorials, components and a dash book to the README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added a new plotly logo in the image field, as the prior svg link was broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and firstly thank you for taking the time to contribute! Apologies for not seeing this earlier I didn't get a notification for it.
Regarding the changes I have a few pieces of feedback:
- The image update is great, what do you think of saving the svg to the repo and using a relative reference to include it in the markdown? That way the image isn't prone to link rot.
- The PR you've raised isn't on
master
, so the diff makes it hard to review what you've added in this PR. Could you re-raise onmaster
? - Similar to the point above, separate commits for the changes you've made e.g.
Add new tutorials
,Alpha sort sections
, particular giving you have alpha-sorted the list, which increases the diff to review.- Nit pick - I'd like to keep the Contributors as an append list to show the order of first contribution to the project.
- The OG/meta awesome list is not alpha sorted, and it isn't included in the definition of the formatting of an awesome list.
Arranged the content in alphabetical order, also added some tutorials, popular components & a book
Do you want to be added to the contributors list on the README.md file?
What name would you like?
Pip Install Python
What website would you like your name linked to?
https://pip-install-python.com