Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks Transfer 23-24 TI1.5 Updates #30

Closed
wants to merge 4 commits into from
Closed

Marks Transfer 23-24 TI1.5 Updates #30

wants to merge 4 commits into from

Conversation

aydevworks
Copy link
Collaborator

CTP-2811 Improve UX when push is taking place
CTP-2812 hide push information about "submission log"
CTP-2923 Minor improvements for marks transfer plugin

@aydevworks aydevworks force-pushed the CTP-2923 branch 2 times, most recently from cd965f8 to 7d090aa Compare January 5, 2024 18:21
@aspark21 aspark21 requested a review from stuartlamour January 17, 2024 07:19
@aspark21
Copy link
Collaborator

adding @stuartlamour to the review. I think we should try and find some time to review together during TI planning.

Had my initial look at this, noted a couple of improvements this does deliver:

  • clicking on the "transfer records exists" icon takes you to the activity level view
  • progress bar once the task is running

but also a couple of quirks:

  • we're not setting expectations about how long it's going to take or what's going on. after a user clicks, it just starts whirling & would likely be assumed to be broken
  • if people click on push from course level view, it's very unlikely they will see the transfer failures which are seen in the activity level view.
  • we have removed the ability to transfer records from the activity level view entirely

In terms of how we address this, some of the ideas that come to mind:

  • make clear that a task is queued & it could take an hour to process
  • send user an email when transfer is complete with a list of any errors on the "grade push" aspect (i.e. not for submission log) that they will have to address through other means - that should link back to the activity view and some documentation about how they can be addressed which Kerry has worked on I believe
  • (if "the transfer" is a result of a push all at course level, then maybe this should come together as one summary email once all tasks are complete rather than separate ones for each activity / adhoc task)

@aydevworks aydevworks marked this pull request as draft January 22, 2024 09:46
@aydevworks
Copy link
Collaborator Author

This PR is replaced by #32

@aydevworks aydevworks closed this Jan 30, 2024
@aspark21 aspark21 deleted the CTP-2923 branch February 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants