Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement refactored Nextflow test workflows #139

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

nwiltsie
Copy link
Member

@nwiltsie nwiltsie commented Apr 5, 2024

Description

This incorporates the new testing workflows implemented in uclahs-cds/tool-Nextflow-action#33.

Once this PR is merged, the workflow mentioned in #138 should be re-enabled.

Checklist

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample with run_delly = true, run_manta = true, run_qc = true. For run_delly = true, I have tested 'variant_type' set to gSV, gCNV, and both. The paths to the test config files and output directories are captured above in the Testing Results section.

@nwiltsie nwiltsie requested a review from a team as a code owner April 5, 2024 23:11
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nwiltsie nwiltsie merged commit 16eead0 into main Apr 12, 2024
5 checks passed
@nwiltsie nwiltsie deleted the nwiltsie-reimplement-tests branch April 12, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants