fix: change how aboveNodes/belowNodes are applied

udecode · Jan 25, 2025 · b012dc1 · b012dc1
1 parent e71cbcc
commit b012dc1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/.changeset/eight-melons-perform.md b/.changeset/eight-melons-perform.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-core': patch
+---
+
+change `aboveNodes` and `belowNodes` to React component instead of direct function call"
diff --git a/packages/core/src/lib/static/pluginRenderElementStatic.tsx b/packages/core/src/lib/static/pluginRenderElementStatic.tsx
@@ -47,10 +47,10 @@ export const pluginRenderElementStatic = (
       }) as any;
 
       belowNodes.forEach((withHOC) => {
-        const hoc = withHOC({ ...nodeProps, key } as any);
+        const HOC = withHOC({ ...nodeProps, key } as any);
 
-        if (hoc) {
-          children = hoc({ ...nodeProps, children } as any);
+        if (HOC) {
+          children = <HOC {...nodeProps}>{children}</HOC>;
         }
       });
 
@@ -59,10 +59,10 @@ export const pluginRenderElementStatic = (
       );
 
       aboveNodes.forEach((withHOC) => {
-        const hoc = withHOC({ ...nodeProps, key } as any);
+        const HOC = withHOC({ ...nodeProps, key } as any);
 
-        if (hoc) {
-          component = hoc({ ...nodeProps, children: component } as any);
+        if (HOC) {
+          component = <HOC {...nodeProps}>{component}</HOC>;
         }
       });
 

diff --git a/packages/core/src/react/utils/pluginRenderElement.tsx b/packages/core/src/react/utils/pluginRenderElement.tsx
@@ -50,20 +50,20 @@ function ElementContent({
   let children = _children;
 
   belowNodes.forEach((withHOC) => {
-    const hoc = withHOC({ ...nodeProps, key } as any);
+    const HOC = withHOC({ ...nodeProps, key } as any);
 
-    if (hoc) {
-      children = hoc({ ...nodeProps, children } as any);
+    if (HOC) {
+      children = <HOC {...nodeProps}>{children}</HOC>;
     }
   });
 
   let component: React.ReactNode = <Element {...nodeProps}>{children}</Element>;
 
   aboveNodes.forEach((withHOC) => {
-    const hoc = withHOC({ ...nodeProps, key } as any);
+    const HOC = withHOC({ ...nodeProps, key } as any);
 
-    if (hoc) {
-      component = hoc({ ...nodeProps, children: component } as any);
+    if (HOC) {
+      component = <HOC {...nodeProps}>{component}</HOC>;
     }
   });