-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple hotkeys for headings #539
Conversation
Codecov Report
@@ Coverage Diff @@
## next #539 +/- ##
==========================================
- Coverage 76.93% 76.61% -0.32%
==========================================
Files 339 339
Lines 4063 4076 +13
Branches 871 875 +4
==========================================
- Hits 3126 3123 -3
- Misses 933 949 +16
Partials 4 4
Continue to review full report at Codecov.
|
plugins.push( | ||
HeadingPlugin({ | ||
...options, | ||
h1: { | ||
...options.h1, | ||
hotkey: ['mod+opt+1', 'mod+shift+1'], | ||
}, | ||
h2: { | ||
...options.h2, | ||
hotkey: ['mod+opt+2', 'mod+shift+2'], | ||
}, | ||
h3: { | ||
...options.h3, | ||
hotkey: ['mod+opt+3', 'mod+shift+3'], | ||
}, | ||
}) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set these options in options
so we don't have to duplicate in all stories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this update is what you had in mind, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Issue
When specifying options for headings, only 1 hotkey would get handled (refs #518)
What I did
Checklist
yarn storybook
).stories
for plugins,knobs
for options.