-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emoji proof of concept #638
Conversation
Codecov Report
@@ Coverage Diff @@
## next #638 +/- ##
===========================================
- Coverage 90.13% 63.69% -26.45%
===========================================
Files 289 159 -130
Lines 2838 1837 -1001
Branches 460 493 +33
===========================================
- Hits 2558 1170 -1388
- Misses 280 663 +383
- Partials 0 4 +4
Continue to review full report at Codecov.
|
I've been thinking of doing something similar for a while, so I'm really excited to see this! |
Great! Your approach looks good to me, I would also use the combobox for that. We can discuss later on which emoji picker to use as there is many in the field, e.g. https://github.com/missive/emoji-mart. It would be perfect to decouple the picker from the plugin (slate logic). |
Thanks for the pointer on The current approach is text between colons is replaced with an emoji, or you can use the combobox which inserts an emoji directly. TBD is skin variant preferences. Emoji-mart uses a global skin variant preference which makes sense from a usability standpoint since the colon syntax is a bit confusing and verbose New Todos
Here's a gif 🎉 |
Great!
Let's move the picker design discussion to #639 |
Closed as we're deleting the |
Issue
Create an example to replace emoji names between
:
and:
with the corresponding emoji.What I did
Created a simple proof of concept using emojis from emoji.json.
Next steps.
The committed emoji.json file would need to be minified and simplified before a merge. This PR is just a RFC.
Before I do any of these I wanted to make sure the changes would be useful! If you want to take a different approach feel free to close this PR!
Alternatives
I thought about using the AutoFormat plugin but I would need to change some of the logic to support emoji matching.
For example you probably don't want to pass a list of a couple thousand markup strings to check for formatting, a dict is faster. Also it feels more intuitive to insert the emoji when the second
:
is typed rather than after:
followed by a space.Checklist
yarn storybook
).stories
for plugins,knobs
for options.