Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension-code-block): #3604 paste code from vscode #3606

Merged
merged 4 commits into from
May 17, 2024
+12 −16
Merged

fix(extension-code-block): #3604 paste code from vscode #3606

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb67e27
fix(extension-code-block): paste code from vscode
aliasliao Jan 8, 2023
c959c18
fix: remove unused import
aliasliao Feb 9, 2023
b484c45
fix: put cursor inside the created code block
aliasliao May 24, 2023
c0f119b
Merge branch 'main' into fix/code-block-paste-from-vscode
nperez0111 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions packages/extension-code-block/src/code-block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,25 +275,21 @@ export const CodeBlock = Node.create<CodeBlockOptions>({
return false
}

const { tr } = view.state

// create an empty code block´
// if the cursor is at the absolute end of the document, insert the code block before the cursor instead
// of replacing the selection as the replaceSelectionWith function will cause the insertion to
// happen at the previous node
if (view.state.selection.from === view.state.doc.nodeSize - (1 + (view.state.selection.$to.depth * 2))) {
tr.insert(view.state.selection.from - 1, this.type.create({ language }))
} else {
tr.replaceSelectionWith(this.type.create({ language }))
}

// put cursor inside the newly created code block
tr.setSelection(TextSelection.near(tr.doc.resolve(Math.max(0, tr.selection.from - 2))))
const { tr, schema } = view.state

// add text to code block
// prepare a text node
// strip carriage return chars from text pasted as code
// see: https://github.com/ProseMirror/prosemirror-view/commit/a50a6bcceb4ce52ac8fcc6162488d8875613aacd
tr.insertText(text.replace(/\r\n?/g, '\n'))
const textNode = schema.text(text.replace(/\r\n?/g, '\n'))

// create a code block with the text node
// replace selection with the code block
tr.replaceSelectionWith(this.type.create({ language }, textNode))

if (tr.selection.$from.parent.type !== this.type) {
// put cursor inside the newly created code block
tr.setSelection(TextSelection.near(tr.doc.resolve(Math.max(0, tr.selection.from - 2))))
}

// store meta information
// this is useful for other plugins that depends on the paste event
Expand Down