Initialize editor before setting event handlers #4916
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Currently, the editor is initialized after the callback bindings are hooked up. The two
useEffect
call order should be swapped. The one that hooks up callbacks is run first, then the one where the instance is created is run second. This means there is an attempt to set bindings when the editor does not exists. And once it is created, it needs to re-render and hook up the callbacks again.How did you accomplish your changes
Moving
useEffect
that creates editor instance to be the first one to run.How have you tested your changes
I have tested it with my basic editor. I haven't run extensive testing.
How can we verify your changes
It should still work the same way it does now from API and user perspective. There will be just one less re-render on initial mount.
Checklist