build(deps): bump prosemirror-trailing-node to 2.0.8 #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LoneRifle
force-pushed
the
main
branch
2 times, most recently
from
52f5696 to
ac58c21
Compare
|
@bdbch @svenadlung - I believe there is a package that is downstream from this one that would benefit from this PR. Are you happy to have a look at this change? It shouldn't change behaviour, and would slightly decrease the total number of dependencies needed for Tiptap. |
LoneRifle
force-pushed
the
main
branch
2 times, most recently
from
793169c to
ccdc36c
Compare
|
Seems like this PR only changed the package-lock.json but no package.json? |
|
@bdbch - that's my fault for not understanding the structure of this repo. I'll put a change in when I get the chance. |
LoneRifle
force-pushed
the
main
branch
2 times, most recently
from
421c99a to
e688008
Compare
|
@bdbch - updated the PR so that |
nperez0111
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Bump prosemirror-trailing-node to 2.0.8 to pick up a change that drops
@remirror/core-helpers.The latter package was heavy, bringing in several additional dependencies, but was only used to create
an array of unique elements, and to check for the presence of elements in arrays.
Accordingly, they have been replaced in 2.0.8 with equivalent code that relies on standard built-in objects.
How did you accomplish your changes
npm update prosemirror-trailing-nodeHow have you tested your changes
N/A - trivial dependency upgrade
How can we verify your changes
Ad-hoc testing in dev
Remarks
This PR is submitted through the course of work done for @opengovsg, whose Starter Kit project is dependent on TipTap
Checklist
Related issues
remirror/remirror#2245
remirror/remirror#2247