test: get tests running on macOS again by leveraging built-in platform detection #5144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
The tests were failing to run on a macOS machine because the keyboard shortcut for strike was trying to implement it's own platform detection.
Instead of relying on the existing keyboard shortcut code:
tiptap/packages/core/src/commands/keyboardShortcut.ts
Lines 30 to 34 in b941eea
The tests that were being run only ever sent the CTRL key instead of using the platform-independent
modKey
Implementation Approach
Simplify the keyboard shortcut handler to utilize the built-in Mod which means CMD on macOS and CTRL on Windows
Testing Done
I ran the demo src/Marks/Strike and everything worked as expected.
Verification Steps
Run the tests on macOS host, and on CI. Verify shortcut on your own
Additional Notes
Checklist
feat: Implement new feature
orchore(deps): Update dependencies
)Related Issues