fix(react): useEditor
should not destroy instances that are still mounted
#5338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This forces the editor to re-use the editor instance that existed prior to an unmount and remount of the same component.
This fixes a bug in
React.StrictMode
introduced with the latest performance updates by PR #5161Implementation Approach
Testing Done
I made the Performance test playground run in StrictMode and was able to resolve the issue
Verification Steps
Checked StrictMode and normal rendering and they seem fine
Additional Notes
Checklist
Related Issues