Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension-link): update regex to allow numbers in URI #6068

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

timoisik
Copy link
Contributor

Changes Overview

This PR allows numbers in links, especially in emails. Before something like [email protected] did not work.

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: bce96a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/extension-link Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit bce96a6
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/679b6bd8a3ca76000831a18f
😎 Deploy Preview https://deploy-preview-6068--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 29, 2025

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6068

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6068

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6068

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6068

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6068

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6068

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6068

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6068

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6068

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6068

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6068

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6068

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@6068

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6068

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6068

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6068

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6068

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6068

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6068

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6068

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6068

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6068

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6068

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6068

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6068

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6068

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6068

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6068

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6068

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6068

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6068

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6068

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6068

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6068

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6068

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6068

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6068

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6068

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6068

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6068

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6068

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6068

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6068

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6068

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6068

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6068

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6068

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6068

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6068

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6068

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6068

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6068

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6068

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6068

commit: bce96a6

Copy link

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right to me. Is it valid for URLs to have numbers in them too?

@bdbch
Copy link
Member

bdbch commented Jan 29, 2025

Looks good to me too.

Is it valid for URLs to have numbers in them too?

Pretty sure they are

@timoisik timoisik merged commit 5836f76 into develop Jan 30, 2025
15 checks passed
@timoisik timoisik deleted the fix/link-regex branch January 30, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants