Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant optional chaining in starter kit extension #6090

Conversation

arnaugomez
Copy link
Contributor

@arnaugomez arnaugomez commented Feb 7, 2025

Changes Overview

The type of the this.options object is never null or undefined, so I suggest not using optional chaining.

(inside the condition of the if statements, the this.options object is used without optional chaining too).

Apologies if there is something that I missed from the original implementation, which might make it necessary to use optional chaining.

Implementation Approach

Remove optional chaining from the this.options object.

This PR is a refactor and does not change the original functionality of the program.

Testing Done

Run linter and tests

Verification Steps

Run linter and tests

Additional Notes

None

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

None

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 62a58be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/starter-kit Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 62a58be
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/67a6019fdea8a80008ad678a
😎 Deploy Preview https://deploy-preview-6090--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6090

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6090

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6090

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6090

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6090

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6090

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6090

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6090

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6090

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6090

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@6090

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6090

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6090

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6090

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6090

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6090

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6090

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6090

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6090

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6090

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6090

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6090

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6090

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6090

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6090

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6090

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6090

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6090

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6090

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6090

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6090

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6090

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6090

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6090

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6090

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6090

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6090

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6090

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6090

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6090

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6090

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6090

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6090

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6090

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6090

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6090

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6090

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6090

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6090

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6090

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6090

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6090

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6090

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6090

commit: 62a58be

Copy link
Contributor

@alexvcasillas alexvcasillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me since options is not partial and technically should not be null or undefined here 👍🏻

@alexvcasillas alexvcasillas requested a review from bdbch February 7, 2025 12:57
@bdbch bdbch merged commit 3826872 into ueberdosis:develop Feb 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants