Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple equivalent annotations #201

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Prevent multiple equivalent annotations #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion factgenie/static/js/span-annotator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,16 @@ class SpanAnnotator {
// Get the actual end position by adding length of the last token
const maxWithLength = max + String($end.data('content')).length - 1;


// Check for exactly matching annotations
const isExisting = doc.annotations.some(ann =>
ann.start === min &&
ann.start + ann.text.length === maxWithLength + 1 &&
ann.type === this.currentType
);

// Check for overlap if not allowed
if (!this.overlapAllowed && this._hasExistingAnnotations(doc, min, maxWithLength)) {
if ((!this.overlapAllowed && this._hasExistingAnnotations(doc, min, maxWithLength)) || isExisting) {
this._renderAnnotations(objectId);
return;
}
Expand Down