Replace constant 273.16 with con_t0c, a physical constant already def…

…ined.
ufs-community · Nov 17, 2023 · 78cab87 · 78cab87
1 parent e1d21cf
commit 78cab87
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/physics/GFS_MP_generic_post.F90 b/physics/GFS_MP_generic_post.F90
@@ -22,7 +22,7 @@ subroutine GFS_MP_generic_post_run(
         im, levs, kdt, nrcm, nncl, ntcw, ntrac, imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_nssl,    &
         imp_physics_mg, imp_physics_fer_hires, cal_pre, cplflx, cplchm, cpllnd, progsigma, con_g, rhowater, rainmin, dtf, &
         frain, rainc, rain1, rann, xlat, xlon, gt0, gq0, prsl, prsi, phii, tsfc, ice, phil, htop, refl_10cm,              & 
-        imfshalcnv,imfshalcnv_gf,imfdeepcnv,imfdeepcnv_gf,imfdeepcnv_samf,snow, graupel, save_t, save_q,      &
+        imfshalcnv,imfshalcnv_gf,imfdeepcnv,imfdeepcnv_gf,imfdeepcnv_samf, con_t0c, snow, graupel, save_t, save_q,        &
         rain0, ice0, snow0, graupel0, del, rain, domr_diag, domzr_diag, domip_diag, doms_diag, tprcp, srflag, sr, cnvprcp,&
         totprcp, totice, totsnw, totgrp, cnvprcpb, totprcpb, toticeb, totsnwb, totgrpb, rain_cpl, rainc_cpl, snow_cpl,    &
         pwat, frzr, frzrb, frozr, frozrb, tsnowp, tsnowpb, rhonewsn1, exticeden,                                          & 
@@ -44,7 +44,7 @@ subroutine GFS_MP_generic_post_run(
       integer, intent(in) :: imfshalcnv,imfshalcnv_gf,imfdeepcnv,imfdeepcnv_gf,imfdeepcnv_samf
       integer, dimension (:), intent(in) :: htop
       integer                                                :: dfi_radar_max_intervals
-      real(kind=kind_phys),                    intent(in)    :: fh_dfi_radar(:), fhour
+      real(kind=kind_phys),                    intent(in)    :: fh_dfi_radar(:), fhour, con_t0c
       real(kind=kind_phys),                    intent(in)    :: radar_tten_limits(:)
       integer                                                :: ix_dfi_radar(:)
       real(kind=kind_phys), dimension(:,:),    intent(inout) :: gt0,refl_10cm
@@ -145,7 +145,7 @@ subroutine GFS_MP_generic_post_run(
            zfrz(i) = phil(i,1)*onebg 
            do k = levs, 1, -1
              zo(i,k) =  phil(i,k)*onebg 
-             if (gt0(i,k) >= 273.16 .and. lfrz) then
+             if (gt0(i,k) >= con_t0c .and. lfrz) then
               zfrz(i) = zo(i,k)
               lfrz = .false.
              endif

diff --git a/physics/GFS_MP_generic_post.meta b/physics/GFS_MP_generic_post.meta
@@ -312,6 +312,14 @@
   dimensions = ()
   type = integer
   intent = in
+[con_t0c]
+  standard_name = temperature_at_zero_celsius
+  long_name = temperature at 0 degree Celsius
+  units = K
+  dimensions = ()
+  type = real
+  kind = kind_phys
+  intent = in
 [tsfc]
   standard_name = surface_skin_temperature
   long_name = surface skin temperature