[production/RRFS.v1] physics updates for RRFS.v1 code freeze #176
Conversation
haiqinli
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
…nd it will be consistent with convective precipitation"
|
@grantfirl Does more need to be done before this PR will be reviewed/merged? Still trying to understand the process with the production release branch. Thanks! |
|
@MatthewPyle-NOAA We just need to review it and @haiqinli needs to upload the test_changes.list file in ufs-community/ufs-weather-model#2147, assuming that we don't request changes. I'm also working on getting #147 and #159 in |
|
Thanks for the explanation, @grantfirl |
| @@ -21,11 +21,11 @@ module GFS_MP_generic_post | |||
| subroutine GFS_MP_generic_post_run( & | |||
| im, levs, kdt, nrcm, nncl, ntcw, ntrac, imp_physics, imp_physics_gfdl, imp_physics_thompson, imp_physics_nssl, & | |||
| imp_physics_mg, imp_physics_fer_hires, cal_pre, cplflx, cplchm, cpllnd, progsigma, con_g, rhowater, rainmin, dtf, & | |||
| frain, rainc, rain1, rann, xlat, xlon, gt0, gq0, prsl, prsi, phii, tsfc, ice, phil, htop, refl_10cm, & | |||
| frain, rainc, rain1, rann, xlat, xlon, gt0, gq0, prsl, prsi, phii, tsfc, ice, phil, htop, refl_10cm, & | |||
There was a problem hiding this comment.
These are only whitespace changes. Is that intended? If not, please revert this change.
There was a problem hiding this comment.
@grantfirl I will revert this. Thanks.
| @@ -123,7 +123,7 @@ subroutine rrfs_smoke_wrapper_run(im, kte, kme, ktau, dt, garea, land, jdate, | |||
| ebu_smoke,fhist,min_fplume, & | |||
| max_fplume, hwp, hwp_ave, wetness, ndvel, ddvel_inout, & | |||
| peak_hr_out,lu_nofire_out,lu_qfire_out, & | |||
| fire_heat_flux_out, frac_grid_burned_out, kpbl,oro, & | |||
| fire_heat_flux_out, frac_grid_burned_out, kpbl,oro, totprcp, & | |||
There was a problem hiding this comment.
Why are you adding totprcp when you're not using it?
There was a problem hiding this comment.
@grantfirl I will remove this unused variable. Thanks.
| @@ -916,6 +916,14 @@ | |||
| type = real | |||
| kind = kind_phys | |||
| intent = in | |||
| [totprcp] | |||
There was a problem hiding this comment.
Same question. Please remove this change if you're not using totprcp.
There was a problem hiding this comment.
@grantfirl I will remove this unused variable. Thanks.
|
@haiqinli Looks fine with the exception of some minor typo-like things. Once you address those, I'll approve. Please remember to commit the test_changes.list file that is generated now in the ufs-weather-model/tests directory for that PR. |
|
This contains the changes from #163. |
| @@ -1363,7 +1363,8 @@ subroutine drag_suite_run( & | |||
| DO k=kts,km | |||
| wsp=SQRT(uwnd1(i,k)**2 + vwnd1(i,k)**2) | |||
| ! alpha*beta*Cmd*Ccorr*2.109 = 12.*1.*0.005*0.6*2.109 = 0.0759 | |||
| var_temp = 0.0759*EXP(-(zl(i,k)/H_efold)**1.5)*a2* & | |||
| ! Change alpha to 35 -- 0.0759 becomes 0.2214 | |||
| var_temp = 0.2214*EXP(-(zl(i,k)/H_efold)**1.5)*a2* & | |||
There was a problem hiding this comment.
@haiqinli @mdtoyNOAA Will this change affect global and HAFS applications as well ? Have any tests been done to check the impact on applicaitons other than RRFS ?
There was a problem hiding this comment.
We tested this change in the HR3 C768 FV3GFS and detected improvements to the 500hPa ACC scores.
There was a problem hiding this comment.
Mike, that is good know. I'd assume this has major impact on surface winds and turbulent exchange coefficients as well. Did you also see positive impact on grid-to-obs stats ?
There was a problem hiding this comment.
Mike, since this change is hardwired and will be include in HR4. Please record this change in our tracking spreadsheet.
There was a problem hiding this comment.
@yangfanglin Keep in mind that this PR is just targeting the RRFS.v1 branch.
There was a problem hiding this comment.
@MatthewPyle-NOAA I see. So the change is made locally and will not be committed back to the main repo.
There was a problem hiding this comment.
@yangfanglin It may be included in a future PR targeting the main repo, but that will be a separate, future step.
There was a problem hiding this comment.
Mike, that is good know. I'd assume this has major impact on surface winds and turbulent exchange coefficients as well. Did you also see positive impact on grid-to-obs stats ?
In the 10m winds we see significant improvements in RMSE in both west and east CONUS. However, a slight degradation of windspeed bias in west (little change in bias in east).
There was a problem hiding this comment.
For VSDB verification, go to:
https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/hr3gwd01/
The modifications to TOFD are the experiment "HR3GWD01". "HR2D13" is HR2.
grantfirl
changed the title
|
tests are done at ufs-community/ufs-weather-model#2147. @grantfirl can you merge this pr? |
|
@MatthewPyle-NOAA You may go ahead to merge this pr if you have permission. |
|
@jkbk2004 I don't have that permission, at least not yet. |
|
I'll merge it for you |
Thanks! @climbfuji |
|
@climbfuji Thanks. I got a late start this morning. |
This PR includes the following updates:
1). MYNN updates;
2). RUC LSM updates (#163);
3). GF updates for humidity DA; restore scale-awareness in the 1st hour; suppress weak radar reflectivity over water;
4). smoke plume rise updates for stability on WCOSS2;
5). GWD updates to reduce the high 10m wind speed bias.