[production/RRFS.v1] saSAS sigmab initialization changes and and inline post bug fix for RUC LSM

[JiliDong-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This PR follows @JongilHan66 suggestion and aims to reduce the large convective reflectivity caused by saSAS adjustment in the first timestep during a warm start. The issue is likely related to the inconsistency when DA updates the moisture at t but not the moisture from the previous timestep (t-36s). The moisture from the previous timestep is needed for initializing sigmab (updraft area fraction) when calculating qadv (q advection or tendency term).

The PR forces qadv to zero in the first timestep when a namelist parameter sigmab_coldstart is set to .true. It also reduces the lower limit of sigmab from 0.01 to 0.0 in the first timestep.

The PR also resolves an issue found by @ericaligo-NOAA where inline post does not correctly output soil temperature and moisture in grib2 when using RUC LSM. We tracked this to post_fv3 where iSF_SURFACE_PHYSICS is not updated for RUC LSM. This parameter is used in UPP SURFACE.f for soil variables output. The initial iSF_SURFACE_PHYSICS = 2 in post_fv3 and should be updated to 3 when RUC LSM is used. In this PR we set iSF_SURFACE_PHYSICS =3 when nsoil=9 and successfully output the 9 level soil variables.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - https://github.com/NOAA-EMC/fv3atm/pull/869
    * ccpp-physics - https://github.com/ufs-community/ccpp-physics/pull/225
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

• Critical Bugfix: Reason
• High: Reason
• Normal

Git Tracking

UFSWM:

• Closes #
• None

Sub component Pull Requests:

• AQM:
• CDEPS:
• CICE:
• CMEPS:
• CMakeModules:
• FV3:
  • ccpp-physics:
  • atmos_cubed_sphere:
• GOCART:
• HYCOM:
• MOM6:
• NOAHMP:
• WW3:
• fire_behavior:
• stochastic_physics:
• None

UFSWM Blocking Dependencies:

• Blocked by #
• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Adds New Tests/Baselines.
• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.
• New input data.
• Updated input data.

Library Changes/Upgrades:

• Required
  • Library names w/versions:
  • Git Stack Issue (JCSDA/spack-stack#)
• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[jkbk2004]

@JiliDong-NOAA @MatthewPyle-NOAA @rhaesung floating point exception happens with /rap_clm_lake_debug_intel.

146: forrtl: error (75): floating point exception
146: Image              PC                Routine            Line        Source
146: fv3.exe            00000000174CEE3B  Unknown               Unknown  Unknown
146: libpthread-2.28.s  00001473E3BB4D10  Unknown               Unknown  Unknown
146: fv3.exe            0000000016DDD533  set_lvlsxml_              130  SET_LVLSXML.f
146: fv3.exe            0000000015DD27F7  set_outflds_              122  SET_OUTFLDS.f
146: fv3.exe            0000000001DA85DF  post_fv3_mp_post_         187  post_fv3.F90
146: fv3.exe            0000000001D13FEB  module_wrt_grid_c        2123  module_wrt_grid_comp.F90

experiment path on hera: /scratch1/NCEPDEV/stmp2/Jong.Kim/FV3_RT/rt_2987226/rap_clm_lake_debug_intel/err

[JiliDong-NOAA]

The crash seems to be related to inline post. I will take a look. @jkbk2004 @MatthewPyle-NOAA @rhaesung

[JiliDong-NOAA]

The crash seems to be related to inline post. I will take a look. @jkbk2004 @MatthewPyle-NOAA @rhaesung

@jkbk2004 The failure is likely caused by not updating FV3. Now it has been updated. Let me know if you still see problems.

On a different note, I have issues on compiling production/RRFS.v1 on Hera, which worked well before. This is what I did:

$ git clone https://github.com/ufs-community/ufs-weather-model.git
$ cd ufs-weather-model/
$ git checkout production/RRFS.v1
$ git submodule update --init --recursive
$ module use modulefiles
$ module load ufs_hera.intel
$ setenv CMAKE_FLAGS "-DAPP=ATM -DCCPP_SUITES=FV3_RAP_clm_lake -D32BIT=ON -DDEBUG=ON"
$ ./build.sh > & compile.log &

The compiling error is:

/scratch1/NCEPDEV/fv3-cam/Jili.Dong/git_work/debug/ufs-weather-model/FV3/atmos_cubed_sphere/tools/fv_io.F90(98): error #6580: Name in only-list does not exist or is not accessible.   [MPP_COMM_NULL]
                                     mpp_npes, MPP_COMM_NULL
-----------------------------------------------^
/scratch1/NCEPDEV/fv3-cam/Jili.Dong/git_work/debug/ufs-weather-model/FV3/atmos_cubed_sphere/tools/fv_io.F90(106): error #6580: Name in only-list does not exist or is not accessible.   [MPP_GET_DOMAIN_TILE_COMMID]
                                     mpp_get_global_domain, mpp_get_domain_tile_commid, mpp_define_io_domain
------------------------------------------------------------^
/scratch1/NCEPDEV/fv3-cam/Jili.Dong/git_work/debug/ufs-weather-model/FV3/atmos_cubed_sphere/tools/fv_io.F90(483): error #6460: This is not a component name that is defined in the encompassing structure.   [USE_COLLECTIVE]
    Atm(1)%Fv_restart_tile%use_collective = .true.
---------------------------^
...
compilation aborted for /scratch1/NCEPDEV/fv3-cam/Jili.Dong/git_work/debug/ufs-weather-model/FV3/atmos_cubed_sphere/tools/fv_io.F90 (code 1)
make[2]: *** [FV3/atmos_cubed_sphere/CMakeFiles/fv3.dir/build.make:452: FV3/atmos_cubed_sphere/CMakeFiles/fv3.dir/tools/fv_io.F90.o] Error 1

Running RT shows the same compiling error.
BTW, compiling develop is successful. Any thoughts or suggestions?