Fix data shape in qcd hook. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalvesan
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that changes an isolated piece of the QCD estimation.
When invoked with systematic shifts, the shift axis of MC histograms will contain these shifts as categorical axis values. For data, however, we only consider the "nominal" shift.
Currently, this leads to a shape mismatch in the QCD hook. Assuming 3 shifts and therefore 3 x 2 + 1 = 7 variations, and a variable with 40 bins, the "data - mc" subtraction is applied to the shapes
which breaks since operations on scinum Number objects are not broadcasted.
This PR manually
repeat's the shift axis of data to match that of MC, which fixes the issue.