Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LDADD and CFLAGS #4

Closed
wants to merge 1 commit into from
Closed

fix LDADD and CFLAGS #4

wants to merge 1 commit into from

Conversation

dai-vdr
Copy link
Contributor

@dai-vdr dai-vdr commented May 12, 2018

move @GCROOTS_CFLAGS@ from LDADD to CFLAGS

Author: NIIBE Yutaka [email protected]

@kou
Copy link
Member

kou commented Aug 22, 2020

Do you know why this is needed? Any error is occurred?

@dai-vdr
Copy link
Contributor Author

dai-vdr commented Aug 23, 2020

This patch maybe imported at Debian sigscheme 0.8.3-5, but I cannot find why he created this patch.
I checked Debian build logs, there were no architectures with build-failed without this patch (0.8.5-4).

I am sorry to say that I have been forwarding this patch without knowing much about it.
So we can revert this patch and close this issue for now.
If some architectures fail to build, I will reopen again.

Thanks!

@dai-vdr dai-vdr closed this Aug 23, 2020
@dai-vdr dai-vdr deleted the fix_LDADD_and_CFLAGS branch August 25, 2020 05:44
@dai-vdr
Copy link
Contributor Author

dai-vdr commented Aug 25, 2020

all architecture successfully without this patch: https://buildd.debian.org/status/package.php?p=sigscheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants