Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests were written with no consideration of LP64. #6

Closed
wants to merge 1 commit into from
Closed

Some tests were written with no consideration of LP64. #6

wants to merge 1 commit into from

Conversation

dai-vdr
Copy link
Contributor

@dai-vdr dai-vdr commented May 12, 2018

Author: NIIBE Yutaka [email protected]

@kou
Copy link
Member

kou commented Aug 22, 2020

I don't know why this is a right change.
What is solved by TST_TN_FALSE(...) -> TST_TN_TRUE(... == NULL) change?
Why do we need to change only some TST_TN_FALSE(...) not all TST_TN_FALSE(...) like https://github.com/uim/sigscheme/pull/6/files#diff-2133a964ee203d434ef38e65d533478eR81 ?

@dai-vdr
Copy link
Contributor Author

dai-vdr commented Aug 23, 2020

This patch imported at Debian sigscheme 0.8.5-3, but I cannot find why he created this patch.
I checked Debian build logs, there were no architectures with build-failed without this patch (0.8.5-2, 0.8.5-2.1).

I am sorry to say that I have been forwarding this patch without knowing much about it.
So we can revert this patch and close this issue for now.
If some architectures fail to build, I will reopen again.

Thanks!

@dai-vdr dai-vdr closed this Aug 23, 2020
@dai-vdr dai-vdr deleted the consideration_of_LP64 branch August 25, 2020 05:43
@dai-vdr
Copy link
Contributor Author

dai-vdr commented Aug 25, 2020

all architecture successfully without this patch: https://buildd.debian.org/status/package.php?p=sigscheme

@kou
Copy link
Member

kou commented Aug 25, 2020

Thanks for confirming this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants