Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card component "cover" shape proof of concept #803

Draft
wants to merge 77 commits into
base: 4.x
Choose a base branch
from
Draft

Card component "cover" shape proof of concept #803

wants to merge 77 commits into from

Conversation

bspeare
Copy link
Contributor

@bspeare bspeare commented Oct 20, 2022 •
edited
Loading

Resolves #804.

joewhitsitt and others added 30 commits October 12, 2022 15:35
@joewhitsitt
restrict how far node 14 can go
3b29f02
@joewhitsitt
update readme with crucial setup step
590c7ad
@joewhitsitt
ignore the lock file
0045789
@joewhitsitt
update with storybook info
ba6731c
@joewhitsitt
media component barebones
422adb9
@joewhitsitt
initial slot work
df50dc4
@joewhitsitt
pivot to use similar borderless setup for media
34b7af5
@joewhitsitt
fill in additional style info
9acf6d2
@pyrello
Updating dependencies as allowed by package.json. Fixed a few things …
287b218 
…with shared properties.
@pyrello
Added prettier config and made some fixes based on it.
8e695b3
@joewhitsitt
establish story for person teaser card
b44b8bc
@joewhitsitt
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
1add705 
…nish-card-component
@joewhitsitt
switch to local image
54cc9bc
@joewhitsitt
add borderless as default
a7c8955
@joewhitsitt
start cleaning up card scss
979647e
@joewhitsitt
keep like items together
16c5a3e
@joewhitsitt
padding should use REM
3cab869
@joewhitsitt
adjust comment
6612d05
@joewhitsitt
move include to end
1a6ed06
@joewhitsitt
adjust spacing of standard properties and nested selectors
19c4c7f
@joewhitsitt
i think card__media is replaced by media
060898f
@pyrello
Merge branch '4.x' into finish-card-component
646e254
@pyrello
Merge branch '4.x' into finish-card-component
233edac
@joewhitsitt
possible fix for borderless padding combo conflict
c5aaf69
@joewhitsitt
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
ee0a66d 
…nish-card-component
@pyrello
Merge branch '4.x' into finish-card-component
858f747
@pyrello
A bit of linting cleanup.
73b6859
@joewhitsitt
wire up meta and subtitle as slots
ea8a6fa
@joewhitsitt
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
f8ac44d 
…nish-card-component
@joewhitsitt
remove medium and widescreen defaults
aabfdcb
GaryRidgway and others added 28 commits October 19, 2022 14:34
@GaryRidgway
font size scope adjustment
d8d36d5
@GaryRidgway
adjust card control labels and groups
671fa25
@bspeare
cleaned up some unused styles
413eed7
@bspeare
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
bf20cc4 
…nish-card-component
@bspeare
Added container queries for card images and alignment
0f5dff3
@GaryRidgway
added custom viewports, I`m the best coder in the world
174ebf7
@bspeare
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
18c2ba9 
…nish-card-component
@bspeare
Added at support rule on container query for caution
374ce20
@bspeare
Added comments to clarify targeted containers
d56e688
@bspeare
Adjusted container queries and worked on getting media--cover working
0ef21ea
@bspeare
Adjusted card media
d165373
@pyrello
Hide the parameters argType from the table.
dcec4d9
@bspeare
Removed media--cover
ac851fb
@bspeare
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
75736b7 
…nish-card-component
@bspeare
Commented out container queries
5baee16
@bspeare
Undoing scss that was making media--cover work
a92f528
@bspeare
Adjusted mobile margins on media for left/right padded
ed71ce9
@pyrello
Added circle button as fallback for no text.
27e4e7c
@bspeare
Added square to aspect ratio iframe setting
036bc74
@bspeare
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
043ec3c 
…nish-card-component
@GaryRidgway
added button circle prop
1562b62
@GaryRidgway
Merge branch 'finish-card-component' of github.com:uiowa/uids into fi…
7ac8615 
…nish-card-component
@pyrello
Updated default story to be more robust.
2e22bbb
@bspeare
Removed unused code
d84e1ed
@bspeare
Removed more unused code and updated icon story
a4c611d
@bspeare
Updated icon link
371acef
@bspeare
Removed more unused code
62b994d
@bspeare
Added media cover proof of concept
97b55d7
@bspeare bspeare mentioned this pull request Oct 20, 2022
Open
@bspeare bspeare changed the title Card component cover proof of concept Card component "cover" shape proof of concept Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.x - Add "cover" as a shape option for card component
4 participants
@bspeare @joewhitsitt @pyrello @GaryRidgway