Fixing antonio weights for browser consistency #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrello
reviewed
Jan 5, 2023
pyrello
reviewed
Jan 5, 2023
pyrello
reviewed
Jan 5, 2023
pyrello
reviewed
Jan 5, 2023
Co-authored-by: Sean Adams-Hiett <[email protected]>
Co-authored-by: Sean Adams-Hiett <[email protected]>
Co-authored-by: Sean Adams-Hiett <[email protected]>
Co-authored-by: Sean Adams-Hiett <[email protected]>
pyrello
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #772.
This fixes the font-weight issue we were having with safari without having to switch to Google fonts. Also, with upcoming privacy concerns I think it makes sense to continue to locally host our fonts.
There is an update pr with a more updated Antonio.woff font in #828, however that update requires a lot of spacing adjustments that we can avoid but sticking with our older version of Antonio here.
How to test
In Safari, compare https://uids.brand.uiowa.edu/branches/feature_fix_antonio_weight/components/detail/stat--default.html with https://uids.brand.uiowa.edu/components/detail/stat--default.html. The stat font should look thin on uids.brand.uiowa.edu and the feature branch font weight should look thicker.
Compare https://uids.brand.uiowa.edu/branches/feature_fix_antonio_weight/components/detail/stat--default.html in Safari and Chrome and verify that the font weights look the same.