Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out unimplemented uids3 components in uids4 #896

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Conversation

GaryRidgway
Copy link
Contributor

@GaryRidgway GaryRidgway commented Oct 30, 2023

Tracks: #895

To test

  1. pull down this branch of UIDS
  2. Check that the following items are stubbed out in the "Not implemented" section
    Accordion
    Background
    Badge
    Banner
    Blockquote
    Colors
    CTA
    Footer
    Slider
    Stat
    Tables
    Tabs

@GaryRidgway GaryRidgway requested a review from a team October 31, 2023 21:00
@GaryRidgway GaryRidgway changed the title Starting stubs. Stub out unimplemented uids3 components in uids 4 Nov 1, 2023
@GaryRidgway GaryRidgway changed the title Stub out unimplemented uids3 components in uids 4 Stub out unimplemented uids3 components in uids4 Nov 1, 2023
@joewhitsitt joewhitsitt self-assigned this Nov 1, 2023
@joewhitsitt
Copy link
Contributor

I can try to pull and test this

@joewhitsitt
Copy link
Contributor

joewhitsitt commented Nov 1, 2023

Not in-scope but I noticed we have story/basic-example--default available. Should that be removed?

/story/components-stub--info is also showing up. not sure if that was intended based on this PR's summary.

I missed the portion of EoD when this was presented and the conversation after it, but do we want to say, "We are in the process of moving this component to UIDS 4," or should we switch to a less committed, "This component has yet to be implemented in UIDS 4"

@joewhitsitt
Copy link
Contributor

There is a "stub" for every component listed above.

@GaryRidgway
Copy link
Contributor Author

Not in-scope but I noticed we have story/basic-example--default available. Should that be removed?

I think so, if we need it, we can always add it back from an older commit.

/story/components-stub--info is also showing up. not sure if that was intended based on this PR's summary.

Good catch, I have removed that.

I missed the portion of EoD when this was presented and the conversation after it, but do we want to say, "We are in the process of moving this component to UIDS 4," or should we switch to a less committed, "This component has yet to be implemented in UIDS 4"

I like your non committal option! I will add that.

@pyrello
Copy link
Contributor

pyrello commented Nov 2, 2023

I missed the portion of EoD when this was presented and the conversation after it, but do we want to say, "We are in the process of moving this component to UIDS 4," or should we switch to a less committed, "This component has yet to be implemented in UIDS 4"

I like your non committal option! I will add that.

I think we had previously discussed a version of this that included the word "yet" and thought that maybe it conveyed that it was taking a while. The removal of "yet" was meant to make the statement neutral with regard to whether we should have moved it already or not.

@pyrello pyrello self-assigned this Nov 2, 2023
@GaryRidgway
Copy link
Contributor Author

I missed the portion of EoD when this was presented and the conversation after it, but do we want to say, "We are in the process of moving this component to UIDS 4," or should we switch to a less committed, "This component has yet to be implemented in UIDS 4"

I like your non committal option! I will add that.

I think we had previously discussed a version of this that included the word "yet" and thought that maybe it conveyed that it was taking a while. The removal of "yet" was meant to make the statement neutral with regard to whether we should have moved it already or not.

Ah, good point. I've adjusted it again.

@GaryRidgway
Copy link
Contributor Author

Not in-scope but I noticed we have story/basic-example--default available. Should that be removed?

It has now been removed!

@joewhitsitt
Copy link
Contributor

The recent changes have satisfied my concerns. It looks like @pyrello is also taking a look so I am going to hold on approval.

Copy link
Contributor

@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good step towards what we need to move to 4 as the default. Nice work, @GaryRidgway!

@GaryRidgway GaryRidgway merged commit 2d3555d into 4.x Nov 2, 2023
3 checks passed
@GaryRidgway GaryRidgway deleted the 3.x-stubs branch November 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants