-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out unimplemented uids3 components in uids4 #896
Conversation
I can try to pull and test this |
Not in-scope but I noticed we have story/basic-example--default available. Should that be removed? /story/components-stub--info is also showing up. not sure if that was intended based on this PR's summary. I missed the portion of EoD when this was presented and the conversation after it, but do we want to say, "We are in the process of moving this component to UIDS 4," or should we switch to a less committed, "This component has yet to be implemented in UIDS 4" |
There is a "stub" for every component listed above. |
I think so, if we need it, we can always add it back from an older commit.
Good catch, I have removed that.
I like your non committal option! I will add that. |
I think we had previously discussed a version of this that included the word "yet" and thought that maybe it conveyed that it was taking a while. The removal of "yet" was meant to make the statement neutral with regard to whether we should have moved it already or not. |
Ah, good point. I've adjusted it again. |
It has now been removed! |
The recent changes have satisfied my concerns. It looks like @pyrello is also taking a look so I am going to hold on approval. |
…ce redundancy of path to components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good step towards what we need to move to 4 as the default. Nice work, @GaryRidgway!
Tracks: #895
To test
Accordion
Background
Badge
Banner
Blockquote
ColorsCTA
Footer
Slider
Stat
Tables
Tabs