-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook 7 migration #911
Conversation
i'll come back to this tomorrow. |
Heads up, I am fine if we decide to pull out the yarn 3 stuff for now. I was just happy to get it to work. Realized along the way how different it is. |
Good questions. However, I am now running into this locally. Not sure what changed...
Update: had to hard cache reload. but did a bunch of things before that so idk. |
Sounds cool. Looking into to both of these, but haven't had much luck. |
Can hide the whole expandable sidebar item using: in .storybook/manager.js
and in each story:
But this is not what we want. If anything it seems like we want to prevent docs and just show the story. |
@joewhitsitt could you post a quick screenshot of what that would look like? |
The routes still exist but it is not in the sidebar. http://localhost:6006/?path=/story/not-implemented-background--background ![]() |
We could create other doc pages like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and I would approve if I could. @pyrello do you want to review?
Pulling to review |
…he card component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Resolves #900
Don't have NVM? https://github.com/nvm-sh/nvm?tab=readme-ov-file#git-install
nvm install 18
nvm use
yarn -v
should output 3.7.0 otherwise you may need to runcorepack enable
while on node 18.yarn install
yarn storybook
WARN You (or an addon) are using the 'config' preset field. This has been replaced by 'previewAnnotations' and will be removed in 8.0
no code available