Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now builds all components as custom web components #916

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

rramsey
Copy link
Collaborator

@rramsey rramsey commented Dec 20, 2023

Running npm run build creates a dist folder with files that can be used in generic html pages. Had to add style sections to the *.vue files like:

<style scoped lang='scss'>
 @use 'alert';
</style>

Generally, this would replace the import './alert.scss'; line in the script tag.

On a generic index.html created with vi, I can import the built js and add and tags that behave as expected, or close enough.

The downside is that this ends up creating a monolithic 200k js file and it looks like the css in it may not be quite right. Haven't had a chance to look at Ben's fix yet, but that should take care of it.

@rramsey rramsey requested a review from pyrello December 20, 2023 22:31
@rramsey rramsey merged commit d103cd9 into web_components Dec 21, 2023
1 of 2 checks passed
@rramsey rramsey deleted the rlrTests branch December 21, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant