Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x - Banner #950

Merged
merged 79 commits into from
Jan 6, 2025
Merged

4.x - Banner #950

merged 79 commits into from
Jan 6, 2025

Conversation

james917
Copy link
Contributor

@james917 james917 commented Dec 3, 2024 •
edited by pyrello
Loading

Related to #721.

How to test

  • Code review
nvm use && yarn install && yarn storybook
  • Review banner controls and confirm that they are all functional and control the property they are meant to control.
  • Review banner variants (stories). Review prop/control defaults for each story and provide feedback if they don't make sense.
  • Test banner control combinations to ensure options work together.

Specific things to check:

  • A new stories file was added for Media. Confirm that it is not displayed in the Storybook navigation.
  • When there is only one button, the link text is rendered as a pseudo button and the banner title is linked.
    • Click to view the full page view of the banner and confirm that entire banner is clickable with the click-container.
  • Confirm when there is more than one button that the links are directly applied to the buttons and not to the banner title.

@james917 james917 marked this pull request as draft December 3, 2024 16:20
james917 and others added 28 commits December 9, 2024 16:34
@james917
current changes for banner issues with button and placement
db800bc
@james917
fixing styling position for button to display correctly working on al…
f87e87a 
…ignment
@bspeare @james917
[4.x] Stat, Badge, Accordion, and Table components (#943)
0682451 
* Added stat component.

* Added badge component.

* Added Accordion and table components.

* Removed inline comment.

* Updated text for accordion.
@GaryRidgway @james917
Update package.json (#951)
ba78ec5
@bspeare @james917
[Card] Icons (#948)
14fd921 
* Initial sizing for svgs.

* Added adjustments to the card to get icons to render like images within card variants.

* Reverted some changes after adjusting svgs.

* Adjusted icons and widescreen variant.
@james917
fixing options to correctly display
4ba4371
@pyrello
Merge branch '4.x' into banner-component
58b3dae
@bspeare
Updated content_position with classes.
97cacb4
@james917
adding alingment exports for Banner
cf78cfe
@bspeare
Added light/dark gradients.
b6c60c4
@bspeare
Added height to banner classes.
4a09a25
@bspeare
Added media.
53685ff
@bspeare
Added media prop.
186e100
@bspeare
Added mobile_content_below_image defaults.
aaac316
@bspeare
Added button color control.
878fd04
@james917
adding title options
b0ceac0
@bspeare
Getting button_color working.
9899e62
@bspeare
Added headline sizing and headline color properties.
fbb78b2
@james917
changed div in stories to span for title
dc73ec9
@james917
adding anchor tag and span class also adding class updates for headin…
dd71d90 
…g for font style i.e serif
@bspeare
Added missing versions of headlines.
fbcadfb
@bspeare
Got headline styles working.
5a0c150
@bspeare
Added highlight classes and options.
60a79c0
@bspeare
Added content area.
e56fdbd
@bspeare
Started the work adding clicka11y stuff.
9113a48
@james917
removed adding anchor tag in stories.js file to prevent a nested anch…
c5a416a 
…or tag displaying
@bspeare
Added multiple buttons.
3cd8104
@bspeare
Removed unused control for banner.
36e72e2
@pyrello pyrello requested review from a team and bspeare January 2, 2025 15:07
@pyrello pyrello marked this pull request as ready for review January 2, 2025 15:07
@bspeare bspeare assigned bspeare and unassigned pyrello Jan 3, 2025
bspeare
bspeare approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@bspeare bspeare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Going to merge this and start testing on uiowa/uiowa#8343.

@bspeare bspeare merged commit 1fe3055 into 4.x Jan 6, 2025
2 checks passed
@bspeare bspeare deleted the banner-component branch January 6, 2025 16:36
@bspeare bspeare mentioned this pull request Jan 6, 2025
Merged
@pyrello pyrello mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrello pyrello pyrello left review comments

@bspeare bspeare bspeare approved these changes

Assignees

@bspeare bspeare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@james917 @pyrello @bspeare @e-marie-w @GaryRidgway