Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated package.json #960

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Updated package.json #960

merged 2 commits into from
Dec 23, 2024

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Dec 19, 2024 •
edited
Loading

Resolution for uiowa/brand-icons#35 (comment)

To test

  • Code review.
  • Trying swapping out UIDS in SiteNow using this commit: 3e55b07e4d199d2e9b633d33c4bf6ce139b2c97a. Change the reference in docroot/themes/custom/uids_base/package.json.
  • Then run:
ddev yarn upgrade @uiowa/uids && ddev blt frontend
  • Ensure no issues with build processes from above commands running.

@pyrello pyrello requested review from bspeare and a team December 19, 2024 20:29
@pyrello pyrello assigned pyrello and unassigned pyrello Dec 23, 2024
@pyrello pyrello marked this pull request as ready for review December 23, 2024 17:35
@james917 james917 self-requested a review December 23, 2024 17:37
@james917 james917 self-assigned this Dec 23, 2024
james917
james917 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@james917 james917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running the ddev yarn upgrade @uiowa/uids && ddev blt frontend it built correctly.

@james917 james917 merged commit b3bd443 into 4.x Dec 23, 2024
4 checks passed
@james917 james917 deleted the exports_update branch December 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james917 james917 james917 approved these changes

@bspeare bspeare Awaiting requested review from bspeare

Assignees

@james917 james917

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyrello @james917