Skip to content

Commit

Permalink
Imported nxcomp-3.3.0-4.tar.gz
Browse files Browse the repository at this point in the history
Summary: Imported nxcomp-3.3.0-4.tar.gz
Keywords:

Imported nxcomp-3.3.0-4.tar.gz
into Git repository
  • Loading branch information
Reinhard Tartler committed Nov 13, 2011
1 parent 95ce6b7 commit ca416e7
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 21 deletions.
8 changes: 8 additions & 0 deletions nxcomp/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
ChangeLog:

nxcomp-3.3.0-4

- Check if the variable storing the ping time exceeded the maximum
integer value.

- Recover incorrect sequence number when the proxy is not connected
to an agent.

nxcomp-3.3.0-3

- Removed a condition in ClientChannel that caused a loss in event
Expand Down
26 changes: 6 additions & 20 deletions nxcomp/ClientChannel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4539,24 +4539,6 @@ int ClientChannel::handleWrite(const unsigned char *message, unsigned int length
lastSequence_ = serverSequence_;
}
}
/*
FIXME: This block was added, otherwise we have a loss
of the nxagent events.
*/
else
{
#ifdef DEBUG
*logofs << "handleWrite: Updating last event's sequence "
<< lastSequence_ << " to X server's sequence number "
<< serverSequence_ << " for FD#" << fd_
<< ".\n" << logofs_flush;
#endif

lastSequence_ = serverSequence_;
}

/*
FIXME: This causes the loss of the nxagent events.

//
// Check if by producing events at client side we
Expand All @@ -4565,7 +4547,12 @@ FIXME: This causes the loss of the nxagent events.
// comply with the last one known by client.
//

if (serverSequence_ > lastSequence_)
/*
FIXME: Recover the sequence number if the proxy
is not connected to an agent.
*/
if (serverSequence_ > lastSequence_ ||
control -> SessionMode != session_proxy)
{
#ifdef DEBUG
*logofs << "handleWrite: Updating last event's sequence "
Expand All @@ -4589,7 +4576,6 @@ FIXME: This causes the loss of the nxagent events.
<< logofs_flush;
}
#endif
*/

//
// Check if remote side used fast encoding.
Expand Down
2 changes: 1 addition & 1 deletion nxcomp/Proxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3645,7 +3645,7 @@ int Proxy::handlePing()
{
int diffPing = diffTimestamp(timeouts_.pingTs, nowTs);

if (diffPing >= (control -> PingTimeout -
if (diffPing < 0 || diffPing >= (control -> PingTimeout -
control -> LatencyTimeout * 5))
{
#if defined(TEST) || defined(INFO) || defined(PING)
Expand Down

0 comments on commit ca416e7

Please sign in to comment.