Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 QA Added acceptance tests for Dictionary #15479

Merged
merged 11 commits into from
Jan 23, 2024

Conversation

nhudinh0309
Copy link
Contributor

Updated api tests for Dictionary
Added .udt files to test the import dictionary function
Added ui tests for Dictionary
Bumped version of helpers

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments

@nhudinh0309
Copy link
Contributor Author

Fixed comments

@nhudinh0309 nhudinh0309 requested a review from andr317c January 23, 2024 04:03
Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@nhudinh0309 nhudinh0309 requested a review from andr317c January 23, 2024 08:38
Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests good! :D

@andr317c andr317c merged commit 8bf8483 into v14/dev Jan 23, 2024
4 of 6 checks passed
@andr317c andr317c deleted the v14/QA/dictionary-acceptance-tests branch January 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants