Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTagsForEntityType should only return tags from not trashed entites and published content #15554

Closed
wants to merge 3 commits into from

Merge branch 'contrib' into git-15524

52ebf90
Select commit
Loading
Failed to load commit list.
Closed

GetTagsForEntityType should only return tags from not trashed entites and published content #15554

Merge branch 'contrib' into git-15524
52ebf90
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) failed Jan 29, 2025 in 36s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.24 (8.74 -> 8.50)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method TagRepositoryTest.cs: Can_Get_Tags_For_Entity_Type_With_Trashed_Entity

Annotations

Check warning on line 774 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/TagRepositoryTest.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

❌ New issue: Large Method 

Can_Get_Tags_For_Entity_Type_With_Trashed_Entity has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis