Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split force for publish descendants into separate options for publish unpublish and re-publish unedited (15) #18270

Merged
merged 13 commits into from
Feb 12, 2025
Merged

Split force for publish descendants into separate options for publish unpublish and re-publish unedited (15) #18270

merged 13 commits into from
Feb 12, 2025

Conversation

AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Resolves: #13739

Description

This is the 15 equivalent of #18249. Please see that PR for description and testing notes.

@AndyButland AndyButland requested a review from Migaroez February 10, 2025 05:56
Migaroez
Migaroez reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@Migaroez Migaroez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the code.
Test coverage seems mostly ok and the minimal update of the tests which is inline with converting the bool to enum in code makes me hopeful that we aren't breaking anything.

Still some manual testing left to do

src/Umbraco.Core/Models/PublishBranchForceOptions.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/ContentService.cs Outdated Show resolved Hide resolved
...o.Tests.Integration/Umbraco.Infrastructure/Services/ContentPublishingServiceTests.Publish.cs Outdated Show resolved Hide resolved
@AndyButland AndyButland mentioned this pull request Feb 12, 2025
Open
5 tasks
@AndyButland AndyButland merged commit 59c2205 into v15/dev Feb 12, 2025
29 checks passed
@AndyButland AndyButland deleted the v15/feature/force-republish-descendents branch February 12, 2025 11:05
@AndyButland AndyButland mentioned this pull request Feb 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Migaroez Migaroez Migaroez approved these changes

Assignees
No one assigned
Labels
area/backend area/frontend status/needs-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyButland @Migaroez