New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Data mapping extension + aligning reference lists #18318

Merged

nielslyngsoe merged 112 commits into v15/dev from v15/feature/$type-data-mapper-extension

Feb 20, 2025

Merged

Feature: Data mapping extension + aligning reference lists #18318

align naming

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Feb 20, 2025 in 1m 14s

CodeScene PR Check

Quality Gate Failed

Code Health Improved (2 files improve in Code Health)

Gates Failed
Enforce advisory code health rules (2 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce advisory code health rules	Violations	Code Health Impact
data-mapper.ts	1 advisory rule	10.00 → 9.58	Suppress
data-mapping-resolver.ts	1 advisory rule	10.00 → 9.69	Suppress

View Improvements

File	Code Health Impact	Categories Improved
document-references-workspace-view-info.element.ts	9.39 → 10.00	Code Duplication
media-references-workspace-info-app.element.ts	9.39 → 10.00	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

Complex Method data-mapper.ts: UmbDataMapper.map
Complex Method data-mapping-resolver.ts: UmbDataMappingResolver.resolve

✅ Improving Code Health:

Code Duplication document-references-workspace-view-info.element.ts
Code Duplication media-references-workspace-info-app.element.ts

Annotations

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/reference/info-app/document-references-workspace-view-info.element.ts

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Code Duplication

The module no longer contains too many functions with similar structure

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/media/media/reference/info-app/media-references-workspace-info-app.element.ts

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Code Duplication

The module no longer contains too many functions with similar structure

Check warning on line 42 in src/Umbraco.Web.UI.Client/src/packages/core/repository/data-mapper/data-mapper.ts

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbDataMapper.map has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 43 in src/Umbraco.Web.UI.Client/src/packages/core/repository/data-mapper/mapping/data-mapping-resolver.ts

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbDataMappingResolver.resolve has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

View more details on CodeScene Delta Analysis