Feature: Delete/Trash referenced by #18351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/delete-referenced-by
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-ref.element.ts
…re/delete-referenced-by
…re/delete-referenced-by
Base automatically changed from
v15/feature/$type-data-mapper-extension
to
v15/dev
February 20, 2025 14:48
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/documents/documents/reference/repository/document-reference.server.data.ts # src/Umbraco.Web.UI.Client/src/packages/media/media/item/manifests.ts # src/Umbraco.Web.UI.Client/src/packages/media/media/reference/repository/media-reference.server.data.ts # src/Umbraco.Web.UI.Client/src/packages/relations/relations/types.ts # src/Umbraco.Web.UI.Client/utils/all-umb-consts/index.ts
|
|
||
| async #initData() { | ||
| if (!this.data) { | ||
| this.#itemRepository?.destroy(); |
There was a problem hiding this comment.
Shouldn't we just already destroy the itemRepository if it exists at this point.
Aka. removing the condition around it. :-)
There was a problem hiding this comment.
Ah well, I mean move it above the condition
nielslyngsoe
approved these changes
Feb 20, 2025
|
@nielslyngsoe There is a fix for ref elements here: umbraco/Umbraco.UI#1015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #18318 - Review this first
This PR introduces two new kinds of dialogs 'trashWithRelation' and 'deleteWithRelation'. They are both used for entities that support dependency relations. Compared to regular trash and delete dialog, they require a referenceRepositoryAlias as part of the manifest, which is used to look up items referenced by the item being deleted or any descendants of the item with references.
Below you can see example screenshots of the dialogs.
Trash Document dialog (same experience for media)
Delete Document dialog (same experience for media)