Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Bulk Delete/Trash referenced by #18393

Open
wants to merge 178 commits into
base: v15/dev
Choose a base branch
from

import global components

9339a6e
Select commit
Loading
Failed to load commit list.
Open

Feature: Bulk Delete/Trash referenced by #18393

import global components
9339a6e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Feb 21, 2025 in 1m 0s

CodeScene PR Check

Quality Gate Failed

Code Health Improved (1 files improve in Code Health)

Gates Failed
Enforce advisory code health rules (2 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
confirm-bulk-action-entity-references.element.ts 1 advisory rule 10.00 → 9.45 Suppress
data-mapping-resolver.ts 1 advisory rule 10.00 → 9.69 Suppress
View Improvements
File Code Health Impact Categories Improved
detail-repository-base.ts 9.39 → 10.00 Code Duplication

Absence of Expected Change Pattern

  • Umbraco-CMS/src/Umbraco.Web.UI.Client/src/external/backend-api/src/types.gen.ts is usually changed with: Umbraco-CMS/src/Umbraco.Web.UI.Client/src/external/backend-api/src/sdk.gen.ts

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method data-mapping-resolver.ts: UmbDataMappingResolver.resolve
  • Complex Method confirm-bulk-action-entity-references.element.ts: UmbConfirmBulkActionModalEntityReferencesElement.initData
  • Complex Method confirm-bulk-action-entity-references.element.ts: UmbConfirmBulkActionModalEntityReferencesElement.loadAreReferenced

✅ Improving Code Health:

  • Code Duplication detail-repository-base.ts

Annotations

Check warning on line 43 in src/Umbraco.Web.UI.Client/src/packages/core/repository/data-mapper/mapping/data-mapping-resolver.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbDataMappingResolver.resolve has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 67 in src/Umbraco.Web.UI.Client/src/packages/relations/relations/entity-actions/local-components/confirm-bulk-action-entity-references.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbConfirmBulkActionModalEntityReferencesElement.initData has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 90 in src/Umbraco.Web.UI.Client/src/packages/relations/relations/entity-actions/local-components/confirm-bulk-action-entity-references.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

UmbConfirmBulkActionModalEntityReferencesElement.loadAreReferenced has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-repository-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Code Duplication

The module no longer contains too many functions with similar structure