Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Filesystem Capability Checks (e.g. volname & st_birthtime) #5 #3

Merged
merged 3 commits into from
May 7, 2024

Conversation

undaunt
Copy link
Owner

@undaunt undaunt commented May 7, 2024

As per @CoordSpace from x1ppy#5

When running freezetag mount on non-Mac filesystems, the current set of file attributes and fuse mount settings cause Runtime Errors with fuse such as fuse: unknown option "volname=Music-freezetag" and trigger the persistent process to instantly crash out.

This patch swaps out checks for OS(es) that don't support these features (e.g. if platform.system() != 'Windows') for checks that see if freezetag is running on the one OS variant that does support them: Darwin. This will allow linux (and maybe windows) users to use freezetag mount with filesystems that do not support that same filesystem feature set as MacOS.

So far this patch has been tested on the latest versions of Ubuntu Server and Debian and it clears the hurdles that prevented the new filesystem from being created, allowing well-behaved FLAC and MP3 files to work as expected.

@undaunt undaunt merged commit 8ad67fb into undaunt:master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants