Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecate plugin and usage of new libraries #684

Merged
merged 72 commits into from
Jan 3, 2025

Conversation

rbourga
Copy link
Contributor

@rbourga rbourga commented Dec 23, 2024

Removal of deprecated plugin older than 6 months.
Addition of new libraries and miscellany enhancements following feed-backs.

undera and others added 30 commits April 5, 2016 13:52
# Conflicts:
#	site/dat/repo/various.json
…o undera-master

# Conflicts:
#	site/dat/repo/various.json
Adding new version of plugins for CLI execution in CI/CD.
rbourga and others added 28 commits June 5, 2023 07:58
Addition of new entry for version 4.13.0.
Removal of deprecated plugins as the github repo doesn't exist anymore.
Which updates the WebSampler default code.
Addition of WegDriver 4.13.0.2
This is to reduce the number of false positives by ensuring that the bin size used when building the histogram is at least as large as the computed value (by using Math.ceil() function).
Removal of deprecated plugin older than 6 month.
Update of libraries for existing plugins and miscellany enhancements.
Formatting mistakes.
@@ -19,3 +19,9 @@ dependency-reduced-pom.xml
.settings/
upload
/editor
plugins/csl/bin/pom.xml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to just ignore *.class files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct; this was a mishap from my part as *.class files were automatically selected by GitHub tool; will be more carefull next time!

On another hand, I am seeing that the Plugins Manager is not downloading "commons-io version 2.18.0".
Is this because version 2.15.1 is already present and needed by the Plugins Manager?
Thing is that my plugins need version 2.18 because commons-csv.1.12.0 does not work with commons-io.2.15.1.

As a workaround, for now, I have manually installed commons-io.2.18.0 to get the plugins working.
But when I uninstall the plugins, it removes commons-io2.18 and then I lose the Plugins Manager UI! To see Plugins Manager again, I have to manually reinstall a version of commons-io!

How can we resolve this conflict ?

Thanks.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only mention of commons-io is in your plugins. This may mean that you conflict with core JMeter libraries, which is very risky. You may look at a more recent versions of JMeter to get one with required version of library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will revert back to commons-csv 1.10 which is compatible with commons-io 2.15.1 that comes with JMeter 5.6.3.
Another PR coming soon!

@undera undera merged commit 82eae0e into undera:master Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants