Updates #289
Updates #289
Conversation
mregsite/settings.py
Outdated
| ), | ||
| 'DEFAULT_THROTTLE_RATES': { | ||
| 'anon': '20/hour', | ||
| 'user': '100/day' |
There was a problem hiding this comment.
100/day seems very low. Actually almost a fifth of what an anonymous user can do.
There was a problem hiding this comment.
What is a good number? 1000/hour? 100/minute As a API user, I would like the time period to be short, to be able to quickly recover if a script run amok. It would be horrible to have to wait an entire day before continuing work, after messing up like that.
mregsite/settings.py
Outdated
| 'LOCATION': '127.0.0.1:11211', | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
please provide instructions on how to run memcached.
requirements.txt
Outdated
| @@ -31,3 +31,5 @@ six==1.12.0 | |||
| uritemplate==3.0.0 | |||
| urllib3==1.24.1 | |||
| coverage==4.5.3 | |||
| memcached==1.4.15 | |||
There was a problem hiding this comment.
This line breaks travis. Possibly uneeded.
There was a problem hiding this comment.
A good tip is to: pip install package .
Then later if you are happy with the package: pip freeze > requirements.txt
|
And also please have better pull request descriptions. |
|
This has been stale for a long time. It seems to aim for two changes:
Is there still a desire to have these changes merged? |
Test coverage report, additional topics for rest_framework, memcache for backend