Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update interval exponential backoff on source collector failure #92

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

pederhan
Copy link
Member

@pederhan pederhan commented Jan 8, 2025

This PR implements more sensible failure strategy defaults for source collector errors. The following is changed:

  1. The error tolerance stuff is now opt-in by default.
  2. The default strategy for source collector errors is now to apply a delay using exponential backoff to the source's update interval on failure.
  3. exit_on_error is now False by default, and must be opted in to. The default behavior is now to use the backoff strategy outlined above. This is technically a breaking change, as failing sources would terminate the application prior to this PR.

All in all, this PR brings in more sensible error handling defaults for source collectors and makes the application more likely to recover from intermittent errors.

@pederhan

This comment was marked as outdated.

@pederhan pederhan changed the title Disable source collectors on error by default - Add update interval exponential backoff on source collector failure Jan 8, 2025
README.md Show resolved Hide resolved
@pederhan pederhan marked this pull request as ready for review January 9, 2025 10:38
@pederhan pederhan merged commit 18349a7 into unioslo:master Jan 13, 2025
5 checks passed
@pederhan pederhan deleted the disable-sources-default branch January 13, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant